Fix doctests related to singular: make them compatible with newer releases of Singular.#41624
Conversation
releases of Singular.
|
works for me on Intel macOS |
|
let's see how it goes on the CI |
|
Documentation preview for this PR (built with commit fd08f92; changes) is ready! 🎉 |
sagemathgh-41624: Fix doctests related to singular: make them compatible with newer releases of Singular. Singular doctests: make compatible with new versions of Singular <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> New versions of Singular, at least on OS X via homebrew, lead to doctest failures: see sagemath#40873. This addresses most of those failures. - In the sandpiles code, it can now handle trailing zeros which may or may not be included in resolutions; this fix is very similar to what was done in sagemath#41138. - In algebraic_scheme.py, the doctest now will not depend on which particular scalar multiples of a polynomial are used to define an ideal, etc. - In `singular/function.pyx`, the previous test now no longer produces an error with some versions of Singular, so it is no longer testing what it was intended to. We delete this doctest. - Various other doctests have been modified to be compatible with both old and new versions. This will fix all but one of the failures in sagemath#40873; the failure in `sage/schemes/curves/affine_curve.py` remains. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41624 Reported by: John H. Palmieri Reviewer(s): Chenxin Zhong, Dima Pasechnik
sagemathgh-41624: Fix doctests related to singular: make them compatible with newer releases of Singular. Singular doctests: make compatible with new versions of Singular <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> New versions of Singular, at least on OS X via homebrew, lead to doctest failures: see sagemath#40873. This addresses most of those failures. - In the sandpiles code, it can now handle trailing zeros which may or may not be included in resolutions; this fix is very similar to what was done in sagemath#41138. - In algebraic_scheme.py, the doctest now will not depend on which particular scalar multiples of a polynomial are used to define an ideal, etc. - In `singular/function.pyx`, the previous test now no longer produces an error with some versions of Singular, so it is no longer testing what it was intended to. We delete this doctest. - Various other doctests have been modified to be compatible with both old and new versions. This will fix all but one of the failures in sagemath#40873; the failure in `sage/schemes/curves/affine_curve.py` remains. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41624 Reported by: John H. Palmieri Reviewer(s): Chenxin Zhong, Dima Pasechnik
|
Which version of singular did this target? I'm getting many other failures with 4.4.1.p5, including some segfaults |
|
segfaults appear to indicate that your version of Singular has problems |
|
Yes, that's why I asked which version was this tested with. It turns out 4.4.1.p5 causes segfaults, which are fixed upstream in Singular/Singular@56681f1 The other failures seem less severe, will follow up in another PR. |
may let them to release a new version |
Looks like another upstream bug, reported at Singular/Singular#1334 |
Follow up to sagemath#41624, fixes the remaining issues
|
Opened #41798 to fix the remaining issues on the sage side |
sagemathgh-41798: Fix test failures with singular 4.4.1.p5 Follow up to sagemath#41624, fixes the remaining issues URL: sagemath#41798 Reported by: Antonio Rojas Reviewer(s): Chenxin Zhong
sagemathgh-41798: Fix test failures with singular 4.4.1.p5 Follow up to sagemath#41624, fixes the remaining issues URL: sagemath#41798 Reported by: Antonio Rojas Reviewer(s): Chenxin Zhong
sagemathgh-41798: Fix test failures with singular 4.4.1.p5 Follow up to sagemath#41624, fixes the remaining issues URL: sagemath#41798 Reported by: Antonio Rojas Reviewer(s): Chenxin Zhong
sagemathgh-41798: Fix test failures with singular 4.4.1.p5 Follow up to sagemath#41624, fixes the remaining issues URL: sagemath#41798 Reported by: Antonio Rojas Reviewer(s): Chenxin Zhong
Singular doctests: make compatible with new versions of Singular
New versions of Singular, at least on OS X via homebrew, lead to doctest failures: see #40873. This addresses most of those failures.
singular/function.pyx, the previous test now no longer produces an error with some versions of Singular, so it is no longer testing what it was intended to. We delete this doctest.This will fix all but one of the failures in #40873; the failure in
sage/schemes/curves/affine_curve.pyremains.📝 Checklist
⌛ Dependencies