Adding number fields for dual schemes#41636
Merged
vbraun merged 2 commits intosagemath:developfrom Feb 25, 2026
Merged
Conversation
|
Documentation preview for this PR (built with commit d60b987; changes) is ready! 🎉 |
tscrim
approved these changes
Feb 17, 2026
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
Strictly speaking, it is redundant to say \QQ)". Once you want to make the change or choose not to, you can set this a positive review.
Minimal correction on the description
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 20, 2026
sagemathgh-41636: Adding number fields for dual schemes There is a method to compute the dual subscheme of a closed subscheme in a projective space. Up to now, it only works when the base ring is either a finite field or `QQ`. It seems to work in more general cases, e.g., number fields, and the code has been changed to allow it, including some tests. I wonder if it is useful to add more cases. I think it works also for the field of the rational functions in several variables with coefficients in a number field. Some fields should be excluded, e.g., the non-exact fields. I checked that the code as it is does not work for the field of rational funtions of an algebraic variety. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41636 Reported by: Enrique Manuel Artal Bartolo Reviewer(s): Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a method to compute the dual subscheme of a closed subscheme in a projective space. Up to now, it only works when the base ring is either a finite field or
QQ. It seems to work in more general cases, e.g., number fields, and the code has been changed to allow it, including some tests.I wonder if it is useful to add more cases. I think it works also for the field of the rational functions in several variables with coefficients in a number field. Some fields should be excluded, e.g., the non-exact fields. I checked that the code as it is does not work for the field of rational funtions of an algebraic variety.
📝 Checklist
⌛ Dependencies