Make broken_circuit_complex return immutable SimplicialComplex#41642
Merged
vbraun merged 2 commits intosagemath:developfrom Feb 25, 2026
Merged
Make broken_circuit_complex return immutable SimplicialComplex#41642vbraun merged 2 commits intosagemath:developfrom
vbraun merged 2 commits intosagemath:developfrom
Conversation
Contributor
Author
|
cc @gmou3 Mirror from: swe-productivity#7. Since the swe project has ended, I will try to submit these patches upstream, starting with this one. |
gmou3
suggested changes
Feb 16, 2026
Contributor
gmou3
left a comment
gmou3
left a comment
There was a problem hiding this comment.
Let's condense the tests a bit.
Co-authored-by: gmou3 <32706872+gmou3@users.noreply.github.com>
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 20, 2026
sagemathgh-41642: Make broken_circuit_complex return immutable SimplicialComplex <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Closes sagemath#41362. The returned `SimplicialComplex` was mutable, causing a ValueError when attempting to hash it (e.g., adding to a set). Fixed by passing `is_immutable=True` to the `SimplicialComplex` constructor. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41642 Reported by: Connector Switch Reviewer(s): Connector Switch, gmou3
Contributor
There is still this one pending: swe-productivity#9. |
Contributor
Author
Here it is: #41721 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41362.
The returned
SimplicialComplexwas mutable, causing a ValueError when attempting to hash it (e.g., adding to a set). Fixed by passingis_immutable=Trueto theSimplicialComplexconstructor.📝 Checklist