implement comparison of AdditiveAbelianGroupWrappers with the same universe#41667
Merged
vbraun merged 2 commits intosagemath:developfrom Mar 22, 2026
Conversation
|
Documentation preview for this PR (built with commit c4bba7f; changes) is ready! 🎉 |
cxzhong
approved these changes
Feb 23, 2026
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 26, 2026
sagemathgh-41667: implement comparison of AdditiveAbelianGroupWrappers with the same universe ...i.e., subgroups of the same ambient group, with respect to inclusion. Currently, this comparison *appears* to work, but it really only compares the *invariants* of the groups, which is significantly weaker than the standard/expected notion of comparison. URL: sagemath#41667 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 28, 2026
sagemathgh-41667: implement comparison of AdditiveAbelianGroupWrappers with the same universe ...i.e., subgroups of the same ambient group, with respect to inclusion. Currently, this comparison *appears* to work, but it really only compares the *invariants* of the groups, which is significantly weaker than the standard/expected notion of comparison. URL: sagemath#41667 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 6, 2026
sagemathgh-41667: implement comparison of AdditiveAbelianGroupWrappers with the same universe ...i.e., subgroups of the same ambient group, with respect to inclusion. Currently, this comparison *appears* to work, but it really only compares the *invariants* of the groups, which is significantly weaker than the standard/expected notion of comparison. URL: sagemath#41667 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 15, 2026
sagemathgh-41667: implement comparison of AdditiveAbelianGroupWrappers with the same universe ...i.e., subgroups of the same ambient group, with respect to inclusion. Currently, this comparison *appears* to work, but it really only compares the *invariants* of the groups, which is significantly weaker than the standard/expected notion of comparison. URL: sagemath#41667 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 18, 2026
sagemathgh-41667: implement comparison of AdditiveAbelianGroupWrappers with the same universe ...i.e., subgroups of the same ambient group, with respect to inclusion. Currently, this comparison *appears* to work, but it really only compares the *invariants* of the groups, which is significantly weaker than the standard/expected notion of comparison. URL: sagemath#41667 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 21, 2026
sagemathgh-41667: implement comparison of AdditiveAbelianGroupWrappers with the same universe ...i.e., subgroups of the same ambient group, with respect to inclusion. Currently, this comparison *appears* to work, but it really only compares the *invariants* of the groups, which is significantly weaker than the standard/expected notion of comparison. URL: sagemath#41667 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong
yyyyx4
deleted the
public/implement_comparison_of_AdditiveAbelianGroupWrappers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...i.e., subgroups of the same ambient group, with respect to inclusion.
Currently, this comparison appears to work, but it really only compares the invariants of the groups, which is significantly weaker than the standard/expected notion of comparison.