add parameter immutable to graph generators in random.py#41739
Merged
vbraun merged 23 commits intosagemath:developfrom Mar 22, 2026
Merged
add parameter immutable to graph generators in random.py#41739vbraun merged 23 commits intosagemath:developfrom
random.py#41739vbraun merged 23 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit d14ef65; changes) is ready! 🎉 |
tscrim
approved these changes
Mar 3, 2026
| else: | ||
| raise ValueError("'algorithm' must be equal to 'networkx' or to 'Sage'.") | ||
| return sageGNP(n, p, seed=seed, immutable=immutable) | ||
| raise ValueError("'algorithm' must be equal to 'networkx' or to 'Sage'.") |
Collaborator
There was a problem hiding this comment.
Suggested change
| raise ValueError("'algorithm' must be equal to 'networkx' or to 'Sage'.") | |
| raise ValueError("'algorithm' must be equal to 'networkx' or to 'Sage'") |
A while-we-are-at-it change.
|
|
||
| g = ToleranceGraph(tolrep) | ||
| g.name("Random tolerance graph") | ||
| g = ToleranceGraph(tolrep, immutable=immutable) |
Collaborator
There was a problem hiding this comment.
ToleranceGraph won't take a name parameter after all of these immutable keyword changes?
Collaborator
Author
There was a problem hiding this comment.
right. I added parameter name to ToleranceGraph
Collaborator
Author
|
Thanks for the review. I also fixed an issue with |
Collaborator
|
Thank you. Positive review. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 6, 2026
sagemathgh-41739: add parameter immutable to graph generators in `random.py` Following discussions in sagemath#39177, we add the option to return immutable graphs to all generators in `src/sage/graphs/generators/random.py`. I agree it is a large PR, but most of the changes are straightforward, except for `RandomBipartite`, `RandomBlockGraph`, `RandomKTree`, `RandomPartialKTree`. A set of tests for checking the behavior of parameter immutable will be added to `generators_test.py` for all generators in a follow-up PR. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41739 Reported by: David Coudert Reviewer(s): David Coudert, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 15, 2026
sagemathgh-41739: add parameter immutable to graph generators in `random.py` Following discussions in sagemath#39177, we add the option to return immutable graphs to all generators in `src/sage/graphs/generators/random.py`. I agree it is a large PR, but most of the changes are straightforward, except for `RandomBipartite`, `RandomBlockGraph`, `RandomKTree`, `RandomPartialKTree`. A set of tests for checking the behavior of parameter immutable will be added to `generators_test.py` for all generators in a follow-up PR. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41739 Reported by: David Coudert Reviewer(s): David Coudert, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 18, 2026
sagemathgh-41739: add parameter immutable to graph generators in `random.py` Following discussions in sagemath#39177, we add the option to return immutable graphs to all generators in `src/sage/graphs/generators/random.py`. I agree it is a large PR, but most of the changes are straightforward, except for `RandomBipartite`, `RandomBlockGraph`, `RandomKTree`, `RandomPartialKTree`. A set of tests for checking the behavior of parameter immutable will be added to `generators_test.py` for all generators in a follow-up PR. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41739 Reported by: David Coudert Reviewer(s): David Coudert, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 21, 2026
sagemathgh-41739: add parameter immutable to graph generators in `random.py` Following discussions in sagemath#39177, we add the option to return immutable graphs to all generators in `src/sage/graphs/generators/random.py`. I agree it is a large PR, but most of the changes are straightforward, except for `RandomBipartite`, `RandomBlockGraph`, `RandomKTree`, `RandomPartialKTree`. A set of tests for checking the behavior of parameter immutable will be added to `generators_test.py` for all generators in a follow-up PR. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41739 Reported by: David Coudert Reviewer(s): David Coudert, Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussions in #39177, we add the option to return immutable graphs to all generators in
src/sage/graphs/generators/random.py.I agree it is a large PR, but most of the changes are straightforward, except for
RandomBipartite,RandomBlockGraph,RandomKTree,RandomPartialKTree.A set of tests for checking the behavior of parameter immutable will be added to
generators_test.pyfor all generators in a follow-up PR.📝 Checklist
⌛ Dependencies