Merged
Conversation
This resolves various occurences of a Windows-specific bug: 64-bit hash not fitting in Windows' 32-bit C long. I hunted them down using the regex search `long.*hash`. There may be more however. Reported in passagemath/passagemath#2220. Follow-up of similar PR: sagemath#41630.
|
Documentation preview for this PR (built with commit 63b83ef; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 6, 2026
sagemathgh-41746: Use `Py_hash_t` for hashes This resolves various occurences of a Windows-specific bug: 64-bit hash not fitting in Windows' 32-bit C long. I hunted them down using the regex search `long.*hash`. There may be more however. Reported in passagemath/passagemath#2220. Follow-up of similar PR: sagemath#41630. URL: sagemath#41746 Reported by: gmou3 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 15, 2026
sagemathgh-41746: Use `Py_hash_t` for hashes This resolves various occurences of a Windows-specific bug: 64-bit hash not fitting in Windows' 32-bit C long. I hunted them down using the regex search `long.*hash`. There may be more however. Reported in passagemath/passagemath#2220. Follow-up of similar PR: sagemath#41630. URL: sagemath#41746 Reported by: gmou3 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 18, 2026
sagemathgh-41746: Use `Py_hash_t` for hashes This resolves various occurences of a Windows-specific bug: 64-bit hash not fitting in Windows' 32-bit C long. I hunted them down using the regex search `long.*hash`. There may be more however. Reported in passagemath/passagemath#2220. Follow-up of similar PR: sagemath#41630. URL: sagemath#41746 Reported by: gmou3 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 21, 2026
sagemathgh-41746: Use `Py_hash_t` for hashes This resolves various occurences of a Windows-specific bug: 64-bit hash not fitting in Windows' 32-bit C long. I hunted them down using the regex search `long.*hash`. There may be more however. Reported in passagemath/passagemath#2220. Follow-up of similar PR: sagemath#41630. URL: sagemath#41746 Reported by: gmou3 Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves various occurences of a Windows-specific bug: 64-bit hash not fitting in Windows' 32-bit C long.
I hunted them down using the regex search
long.*hash. There may be more however.Reported in passagemath/passagemath#2220.
Follow-up of similar PR: #41630.