Remove "needs sage.foo" tags in sage.{sandpiles,probability}#41755
Merged
vbraun merged 2 commits intosagemath:developfrom Mar 22, 2026
Merged
Remove "needs sage.foo" tags in sage.{sandpiles,probability}#41755vbraun merged 2 commits intosagemath:developfrom
vbraun merged 2 commits intosagemath:developfrom
Conversation
These aren't being maintained or used in upstream SageMath.
These aren't being maintained or used in upstream SageMath.
|
Documentation preview for this PR (built with commit 655be1d; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 15, 2026
sagemathgh-41755: Remove "needs sage.foo" tags in sage.{sandpiles,probability} These aren't being used or maintain in upstream SageMath. Eventually it would be nice to stop detecting these "features" over and over again at runtime, but first we have to eliminate all of the tags. Note: I removed both the block-level and per-line tags this time around, to avoid warnings about variables being declared behind one or the other. URL: sagemath#41755 Reported by: Michael Orlitzky Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 18, 2026
sagemathgh-41755: Remove "needs sage.foo" tags in sage.{sandpiles,probability} These aren't being used or maintain in upstream SageMath. Eventually it would be nice to stop detecting these "features" over and over again at runtime, but first we have to eliminate all of the tags. Note: I removed both the block-level and per-line tags this time around, to avoid warnings about variables being declared behind one or the other. URL: sagemath#41755 Reported by: Michael Orlitzky Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 21, 2026
sagemathgh-41755: Remove "needs sage.foo" tags in sage.{sandpiles,probability} These aren't being used or maintain in upstream SageMath. Eventually it would be nice to stop detecting these "features" over and over again at runtime, but first we have to eliminate all of the tags. Note: I removed both the block-level and per-line tags this time around, to avoid warnings about variables being declared behind one or the other. URL: sagemath#41755 Reported by: Michael Orlitzky Reviewer(s): Frédéric Chapoton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These aren't being used or maintain in upstream SageMath. Eventually it would be nice to stop detecting these "features" over and over again at runtime, but first we have to eliminate all of the tags.
Note: I removed both the block-level and per-line tags this time around, to avoid warnings about variables being declared behind one or the other.