Move the flint pxd generation script to tools#41758
Merged
vbraun merged 8 commits intosagemath:developfrom Mar 22, 2026
Merged
Conversation
It's part of sagemath-giac now.
This script is run by a human to generate the pxd files for our flint bindings in sage/libs/flint. We now have a "tools" directory for such things; src/sage_setup/autogen is part of the sage library and should ideally contain only things needed at build time.
Since this README covers all of the other tools, it should mention flint-autogen too.
This has been moved to "tools", which is already ignored.
The path to the flint_autogen.py script is mentioned in a few places that need to be updated now that it has moved.
The autogen script has moved; to avoid confusion, let's ignore the big warning and edit these files.
videlec
reviewed
Mar 5, 2026
| and file_path.parent.name == "nbconvert" | ||
| ) | ||
| or ( | ||
| file_path.name == "giacpy-mkkeywords.py" |
Contributor
There was a problem hiding this comment.
why this giacpy exception disappeared?
Contributor
Author
There was a problem hiding this comment.
I deleted it a long time ago: 60a42a342680d042
|
Documentation preview for this PR (built with commit 678299e; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 6, 2026
Since this script is run by a human (and the changes committed manually), I think it is more appropriate under `tools/` than in `src/sage_setup/autogen`. As evidence for this, we can delete the exception for it in `conftest.py`, which in reality is what made me look at it in the first place. URL: sagemath#41758 Reported by: Michael Orlitzky Reviewer(s): Michael Orlitzky, Vincent Delecroix
Contributor
Author
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 15, 2026
sagemathgh-41758: Move the flint pxd generation script to tools Since this script is run by a human (and the changes committed manually), I think it is more appropriate under `tools/` than in `src/sage_setup/autogen`. As evidence for this, we can delete the exception for it in `conftest.py`, which in reality is what made me look at it in the first place. URL: sagemath#41758 Reported by: Michael Orlitzky Reviewer(s): Michael Orlitzky, Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 18, 2026
sagemathgh-41758: Move the flint pxd generation script to tools Since this script is run by a human (and the changes committed manually), I think it is more appropriate under `tools/` than in `src/sage_setup/autogen`. As evidence for this, we can delete the exception for it in `conftest.py`, which in reality is what made me look at it in the first place. URL: sagemath#41758 Reported by: Michael Orlitzky Reviewer(s): Michael Orlitzky, Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 21, 2026
sagemathgh-41758: Move the flint pxd generation script to tools Since this script is run by a human (and the changes committed manually), I think it is more appropriate under `tools/` than in `src/sage_setup/autogen`. As evidence for this, we can delete the exception for it in `conftest.py`, which in reality is what made me look at it in the first place. URL: sagemath#41758 Reported by: Michael Orlitzky Reviewer(s): Michael Orlitzky, Vincent Delecroix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this script is run by a human (and the changes committed manually), I think it is more appropriate under
tools/than insrc/sage_setup/autogen. As evidence for this, we can delete the exception for it inconftest.py, which in reality is what made me look at it in the first place.