Remove rpy2 workaround in conftest.py#41761
Conversation
|
Documentation preview for this PR (built with commit 79960ad; changes) is ready! 🎉 |
|
I'm a bit confused about how this is working for you as pytest is not able to understand the The "this is a hack" comment mostly referred to that the file using rpy2 should throw a FeatureNotFound error if rpy2 is not available (instead of a ModuleNotFoundError), in which case the file then automatically gets ignored by Lines 149 to 152 in e37154c |
The import of rpy2 is lazy in src/sage/interfaces/r.py and the file is skipped due to a FeatureNotPresentError.
|
Well TBH I assumed that it was not working, and that since it works now, I fixed it. But it was working to begin with! |
0020c55 to
79960ad
Compare
|
Without changing anything in |
tobiasdiez
left a comment
There was a problem hiding this comment.
That's of course very nice ;-)
sagemathgh-41761: Remove rpy2 workaround in conftest.py We currently have a hack in conftest.py for (the possibly absent) rpy2 in `src/sage/interfaces/r.py`, but apparently everything is fine without it. URL: sagemath#41761 Reported by: Michael Orlitzky Reviewer(s): Tobias Diez
sagemathgh-41761: Remove rpy2 workaround in conftest.py We currently have a hack in conftest.py for (the possibly absent) rpy2 in `src/sage/interfaces/r.py`, but apparently everything is fine without it. URL: sagemath#41761 Reported by: Michael Orlitzky Reviewer(s): Tobias Diez
sagemathgh-41761: Remove rpy2 workaround in conftest.py We currently have a hack in conftest.py for (the possibly absent) rpy2 in `src/sage/interfaces/r.py`, but apparently everything is fine without it. URL: sagemath#41761 Reported by: Michael Orlitzky Reviewer(s): Tobias Diez
We currently have a hack in conftest.py for (the possibly absent) rpy2 in
src/sage/interfaces/r.py, but apparently everything is fine without it.