Skip to content

src/combinat: move local references to global index (parking_functions, perfect_matching)#41773

Merged
vbraun merged 4 commits intosagemath:developfrom
aksharabhardwaj766-commits:combinat-refs-parking-perfect
Mar 22, 2026
Merged

src/combinat: move local references to global index (parking_functions, perfect_matching)#41773
vbraun merged 4 commits intosagemath:developfrom
aksharabhardwaj766-commits:combinat-refs-parking-perfect

Conversation

@aksharabhardwaj766-commits
Copy link
Copy Markdown
Contributor

Part of #28445

Moves local reference definitions from:

  • src/sage/combinat/parking_functions.py (4 refs: Beck, Hag08, Shin, GXZ)
  • src/sage/combinat/perfect_matching.py (3 refs: CM, McD, MV)

Comment on lines +5060 to +5064
.. [McD] combinatorics of hyperoctahedral group, double coset algebra and
zonal polynomials (I. G. Macdonald, Symmetric functions and Hall
polynomials, Oxford University Press, second edition, 1995, chapter
VII).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add this as a reference. Instead, see below.

Suggested change
.. [McD] combinatorics of hyperoctahedral group, double coset algebra and
zonal polynomials (I. G. Macdonald, Symmetric functions and Hall
polynomials, Oxford University Press, second edition, 1995, chapter
VII).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed !

Comment thread src/sage/combinat/perfect_matching.py Outdated
Comment on lines +5356 to +5359
.. [MV] combinatorics of orthogonal polynomials (A. de Medicis et
X.Viennot, Moments des q-polynômes de Laguerre et la bijection de
Foata-Zeilberger, Adv. Appl. Math., 15 (1994), 262-304)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference is incorrect. See https://zbmath.org/0812.05074 for the correct title.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed !

@mantepse
Copy link
Copy Markdown
Contributor

mantepse commented Mar 7, 2026

I really appreciate your work, this is very useful!

If at all possible, please check the references with mathscinet or zbmath!

Co-authored-by: Martin Rubey <axiomize@yahoo.de>
Comment on lines 6 to +10
the set `\{1,...,n\}`, it is equivalent to fixpoint-free involutions. These
simple combinatorial objects appear in different domains such as combinatorics
of orthogonal polynomials and of the hyperoctaedral groups (see [MV]_, [McD]_
and also [CM]_):
of orthogonal polynomials and of the hyperoctahedral groups (see [MV]_, Chapter VII of [Mac1995]_
and [CM]_):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something went wrong here!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it!

Copy link
Copy Markdown
Contributor

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 15, 2026
sagemathgh-41773: src/combinat: move local references to global index (parking_functions, perfect_matching)
    
Part of sagemath#28445

Moves local reference definitions from:
- `src/sage/combinat/parking_functions.py` (4 refs: Beck, Hag08, Shin,
GXZ)
- `src/sage/combinat/perfect_matching.py` (3 refs: CM, McD, MV)
    
URL: sagemath#41773
Reported by: Akshara Bhardwaj
Reviewer(s): Akshara Bhardwaj, Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 18, 2026
sagemathgh-41773: src/combinat: move local references to global index (parking_functions, perfect_matching)
    
Part of sagemath#28445

Moves local reference definitions from:
- `src/sage/combinat/parking_functions.py` (4 refs: Beck, Hag08, Shin,
GXZ)
- `src/sage/combinat/perfect_matching.py` (3 refs: CM, McD, MV)
    
URL: sagemath#41773
Reported by: Akshara Bhardwaj
Reviewer(s): Akshara Bhardwaj, Martin Rubey
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 21, 2026
sagemathgh-41773: src/combinat: move local references to global index (parking_functions, perfect_matching)
    
Part of sagemath#28445

Moves local reference definitions from:
- `src/sage/combinat/parking_functions.py` (4 refs: Beck, Hag08, Shin,
GXZ)
- `src/sage/combinat/perfect_matching.py` (3 refs: CM, McD, MV)
    
URL: sagemath#41773
Reported by: Akshara Bhardwaj
Reviewer(s): Akshara Bhardwaj, Martin Rubey
@github-actions
Copy link
Copy Markdown

Documentation preview for this PR (built with commit adbdff5; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@vbraun vbraun merged commit dac5cd9 into sagemath:develop Mar 22, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants