Fix oddity in formatting string inside get_coercion_model().analyse().#41828
Merged
vbraun merged 1 commit intosagemath:developfrom Mar 22, 2026
Merged
Fix oddity in formatting string inside get_coercion_model().analyse().#41828vbraun merged 1 commit intosagemath:developfrom
get_coercion_model().analyse().#41828vbraun merged 1 commit intosagemath:developfrom
Conversation
The trivial code below was choking on that particular line not converting all its arguments. It's indeed visibly wrong. ``` sage: from sage.structure.element import get_coercion_model sage: get_coercion_model().analyse(int(1), int(1)) [...] TypeError: not all arguments converted during string formatting ```
|
Documentation preview for this PR (built with commit 5b2c64d; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 21, 2026
sagemathgh-41828: Fix oddity in formatting string inside `get_coercion_model().analyse()`. The trivial code below was choking on that particular line not converting all its arguments. It's indeed visibly wrong. ``` sage: from sage.structure.element import get_coercion_model sage: get_coercion_model().analyse(int(1), int(1)) [...] TypeError: not all arguments converted during string formatting ``` URL: sagemath#41828 Reported by: Emmanuel Thomé Reviewer(s): Martin Rubey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trivial code below was choking on that particular line not converting all its arguments. It's indeed visibly wrong.