Skip to content

Issue #435#444

Merged
loganxingfang merged 1 commit intosrlabUsask:masterfrom
Bdish22:issue_435_fix
May 23, 2024
Merged

Issue #435#444
loganxingfang merged 1 commit intosrlabUsask:masterfrom
Bdish22:issue_435_fix

Conversation

@Bdish22
Copy link
Copy Markdown

@Bdish22 Bdish22 commented May 23, 2024

No description provided.

@jhs507 jhs507 requested a review from loganxingfang May 23, 2024 19:20
@jhs507
Copy link
Copy Markdown
Collaborator

jhs507 commented May 23, 2024

Thank you for this fix Brenden.

@loganxingfang I have assigned you to review this fix.

If you think it solves the issue I will merge it.

@loganxingfang
Copy link
Copy Markdown
Collaborator

Thank you for this fix Brenden.

@loganxingfang I have assigned you to review this fix.

If you think it solves the issue I will merge it.

@jhs507 I reviewed this code change. It is good. As this is also a bug in Borland CRHM ClassSoilX, I will put this fix in later. The only thing I might do differently is to use 0.0 when comparing to floating value of Zd_front_array[0][hh]

if (NO_Freeze[hh] || Zd_front_array[0][hh] == 0.0)

@loganxingfang loganxingfang merged commit e62364a into srlabUsask:master May 23, 2024
@jhs507
Copy link
Copy Markdown
Collaborator

jhs507 commented May 23, 2024

That is a good catch. I think we should add the 0.0 in now. Instead of reverting the commit I will just make a new one with the edit.

@jhs507
Copy link
Copy Markdown
Collaborator

jhs507 commented May 23, 2024

Actually, since No_Freeze is a long and Zd_front_array is a double I altered it to test the long against 0 and the double against 0.0

103e6ca here is the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants