Skip to content

fix(cli): Only install @trpc/next when router style is page router#1835

Merged
juliusmarminge merged 3 commits intot3-oss:mainfrom
Insik-Han:main
Apr 22, 2024
Merged

fix(cli): Only install @trpc/next when router style is page router#1835
juliusmarminge merged 3 commits intot3-oss:mainfrom
Insik-Han:main

Conversation

@Insik-Han
Copy link

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Only install @trpc/next when router style is page router


Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 2b949a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 1 resolved
Apr 22, 2024 7:45am

@vercel
Copy link

vercel bot commented Apr 22, 2024

@Inshiku-Han is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@juliusmarminge
Copy link
Member

Tests failing: see for example https://github.com/t3-oss/create-t3-app/actions/runs/8777255115/job/24089822115?pr=1835

@juliusmarminge
Copy link
Member

seems like zod 3.23 has changed up some types which has broken t3-env so this pr is unrelated

@juliusmarminge juliusmarminge merged commit f66e30a into t3-oss:main Apr 22, 2024
korawit-dvtx pushed a commit to korawit-dvtx/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
…3-oss#1835)

Co-authored-by: juliusmarminge <julius0216@outlook.com>
HimanshuKumarDutt094 pushed a commit to HimanshuKumarDutt094/create-t3-app that referenced this pull request Nov 23, 2025
…3-oss#1835)

Co-authored-by: juliusmarminge <julius0216@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants