Skip to content

placement, kv: support RuleGroup configuration#2740

Merged
ti-srebot merged 5 commits intotikv:masterfrom
oh-my-tidb:group-storage
Aug 11, 2020
Merged

placement, kv: support RuleGroup configuration#2740
ti-srebot merged 5 commits intotikv:masterfrom
oh-my-tidb:group-storage

Conversation

@disksing
Copy link
Copy Markdown
Contributor

@disksing disksing commented Aug 10, 2020

What problem does this PR solve?

Support RuleGroup level Index and Override properties.
Tracking issue: #2721

What is changed and how it works?

  • kv storage L/S methods
  • update ruleManager
  • add unit test

Check List

Tests

  • Unit test

Code changes

  • Has persistent data change

Release note

  • No release note

@disksing
kv: add rule group l/s methods
cf301ba 
Signed-off-by: disksing <i@disksing.com>
@disksing
update manager
121f358 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the component/placement Placement rule. label Aug 10, 2020
@disksing disksing requested review from HunDunDM and rleungx August 10, 2020 09:53
@Yisaer Yisaer requested review from JmPotato and Yisaer August 10, 2020 10:40
Yisaer
Yisaer approved these changes Aug 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 10, 2020

@Yisaer,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack).

rleungx
rleungx reviewed Aug 10, 2020
View reviewed changes
rleungx
rleungx reviewed Aug 10, 2020
View reviewed changes
@disksing
address comment
76d6868 
Signed-off-by: disksing <i@disksing.com>
@disksing
address comment
94c5e2c 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 11, 2020
@disksing disksing requested a review from rleungx August 11, 2020 02:52
rleungx
rleungx approved these changes Aug 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2020
@disksing
Copy link
Copy Markdown
Contributor Author

disksing commented Aug 11, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 11, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit a2952ca into tikv:master Aug 11, 2020
@disksing disksing deleted the group-storage branch August 11, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yisaer Yisaer Yisaer approved these changes

@rleungx rleungx rleungx approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees

No one assigned

Labels

component/placement Placement rule. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@disksing @ti-srebot @Yisaer @rleungx