Add Debug derive to ProxyClientOptions for better logging#1002
Open
vinodkumarpeddi wants to merge 1 commit intotrunk-rs:mainfrom
Open
Add Debug derive to ProxyClientOptions for better logging#1002vinodkumarpeddi wants to merge 1 commit intotrunk-rs:mainfrom
vinodkumarpeddi wants to merge 1 commit intotrunk-rs:mainfrom
Conversation
ctron
requested changes
Jul 18, 2025
Collaborator
ctron
left a comment
ctron
left a comment
There was a problem hiding this comment.
Two small things I think would improve it.
Was there any AI involved in creating this PR? If so, please add a Assisted-by: <tool> footer to the git commit.
| Default::default() | ||
| } | ||
| ); | ||
| tracing::debug!("Proxy options: {:?}", opts); // Optional debug log |
Collaborator
There was a problem hiding this comment.
I'd appreciate the comment to be removed, as it's obvious:
Suggested change
| tracing::debug!("Proxy options: {:?}", opts); // Optional debug log | |
| tracing::debug!("Proxy options: {opts:#?}"); |
| let no_sys_proxy = opts.no_system_proxy; | ||
| let insecure = opts.insecure; | ||
| let client = self.clients.get_client(opts)?; | ||
| let client = self.clients.get_client(opts.clone())?; |
Collaborator
There was a problem hiding this comment.
If you'd pull the tracing statement above this line, you wouldn't need to clone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
Debugderive to theProxyClientOptionsstruct inproxy.rs. This makes it easier to log and debug the struct during development and troubleshooting.Changes Made
#[derive(Debug)]toProxyClientOptionsinsrc/serve/proxy.rs.Why?
Without
Debug, logging or printing the struct during runtime results in a compile error. This change improves developer experience.Checklist