Apply insecure proxy option to websockets#1007
Open
chunnoo wants to merge 1 commit intotrunk-rs:mainfrom
Open
Conversation
ctron
approved these changes
Aug 5, 2025
Collaborator
ctron
left a comment
ctron
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks great.
I'd appreciate a bit of comments in the code. But it's not a blocker.
chunnoo
force-pushed
the
insecure-websockets
branch
from
1dba2cd to
8645d07
Compare
Author
|
Thanks! Added more comments and made a better effort to make sure the CI passes. |
If the insecure option is set on a websocket proxy, it will use a `rustls` or `native-tls` connector, depending on which features are enabled, that allows insecure TLS connections. If neither of those features are enabled, it will fail to create an insecure connection.
chunnoo
force-pushed
the
insecure-websockets
branch
from
8645d07 to
8711938
Compare
ctron
approved these changes
Aug 5, 2025
|
is there anything holding this back, or is there any special reason why it's not merged yet? |
Collaborator
|
Sorry, I guess I dropped the ball on this. This adds both native-tls and rustls. We already have openssl. I think it would be better to align on one. As we already have openssl, I'd like to stick to that. Theoretically, I'd like to stick to native-tls, however that doesn't seem to provide the server side of things. At least not in the combination we need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the insecure option is set, the proxy uses an insecure
rustlsornative-tlsconnector for establishing a websocket connection to the backend.