Skip to content

Switch to using Golang CI Lint #2503

@phillebaba

Description

@phillebaba

Describe what should be investigated or refactored

Currently Revive is being used to lint Zarf. While it does have a lot of rules it does not integrate well with other linter projects. Golang CI Lint on the other hand wraps a lot of other linter projects with one of them being Revive. Switching linting tool would allow us to keep the existing linter rules while also expanding with more checks.

We should at minimum aim to enable the default linters in Golang CI Lint ontop of Revive.

  • errcheck
  • gosimple
  • govet
  • ineffassign
  • staticcheck
  • unused

Additional context

Golang CI Lint is already being used by uds-cli so we are not the first to use it.

https://github.com/defenseunicorns/uds-cli/blob/main/.golangci.yml

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions