fix: add http connector service to serve health check#3543
Merged
Conversation
mxyng
requested review from
BruceMacD,
dnephin,
jmorganca and
pdevine
as code owners
Collaborator
Author
|
Helm lint failure is related to #3544 |
mxyng
force-pushed
the
mxyng/http-connector
branch
from
1381f19 to
3084888
Compare
BruceMacD
approved these changes
Nov 3, 2022
Collaborator
BruceMacD
left a comment
BruceMacD
left a comment
There was a problem hiding this comment.
lgtm once tests pass (looks like it will pass if re-run)
dnephin
approved these changes
Nov 3, 2022
Contributor
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
I've seen TestConnector_Run flake a few times now, I'l look into that
Contributor
|
OH, it's not a test flake, it's actually failing correctly I think. The test needs to be updated to set the address to |
Contributor
|
I pushed a commit to fix the test failure and fix shutdown of the connector. The pattern in the connector is not quite as nice as what we have in the |
mxyng
added a commit
that referenced
this pull request
Nov 4, 2022
Revert "Merge pull request #3543 from infrahq/mxyng/http-connector"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The connector has a single HTTPS service which is problematic for most health checkers as they tend to default to TCP. This causes an incomplete TLS handshake which shows up in logs as
http: TLS handshake error from <addr>:<port>: EOF. Adding a HTTP service mitigates this since the health checker does not attempt an TLS handshake