Conversation
mxyng
requested review from
BruceMacD,
dnephin,
jmorganca and
pdevine
as code owners
BruceMacD
reviewed
Nov 4, 2022
| func defaultConnectorOptions() connector.Options { | ||
| return connector.Options{ | ||
| Addr: connector.ListenerOptions{ | ||
| HTTP: ":80", |
Collaborator
There was a problem hiding this comment.
Should we allow HTTP listeners from the connector? Seems like we wouldnt want that.
Collaborator
Author
There was a problem hiding this comment.
The HTTP service serves only a health endpoint. This is useful in the common case of external load balancers in public cloud where the load balancer health check often defaults to TCP checks which produces EOF errors when sent to the HTTPS service. By exposing a HTTP endpoint, the connector won't complain when the external load balancer hits it with a TCP handshake. It does not serve the reverse proxy so there's no security risk; sending a request path other than /healthz will return 404
BruceMacD
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Iteration on #3543. Separate out the Helm changes as it will cause problems if image and chart are deploy out of sync. Filter service port to pick out the
httpsservice port instead of using the first, which will behttp.httpwill not work as the destination port since it does not serve the proxy