lsp: Implement LSP opaTestProvider feature in language server#1888
Merged
charlieegan3 merged 3 commits intoopen-policy-agent:mainfrom Feb 24, 2026
Merged
lsp: Implement LSP opaTestProvider feature in language server#1888charlieegan3 merged 3 commits intoopen-policy-agent:mainfrom
charlieegan3 merged 3 commits intoopen-policy-agent:mainfrom
Conversation
charlieegan3
force-pushed
the
server-testing
branch
3 times, most recently
from
8f5db3f to
406e341
Compare
charlieegan3
force-pushed
the
server-testing
branch
from
406e341 to
de8a46b
Compare
charlieegan3
changed the title
charlieegan3
force-pushed
the
server-testing
branch
from
de8a46b to
b7c364a
Compare
srenatus
approved these changes
Feb 24, 2026
Contributor
srenatus
left a comment
srenatus
left a comment
There was a problem hiding this comment.
LGTM. Parameterized tests don't happen to "just work", do they? 🤔
|
|
||
| [](https://github.com/open-policy-agent/regal/actions) | ||
|  | ||
|  |
Contributor
There was a problem hiding this comment.
What do we need? Ah, the runtime bits. 💡
charlieegan3
force-pushed
the
server-testing
branch
from
b7c364a to
1c7fbff
Compare
Contributor
Author
Afraid not yet, I need to dig a little deeper to understand how to reliably detect these. There is also a bit of an issue where each test is run one after the other rather than all at once. I need to understand how to have 'test run all' return acceptable results to update the single test rule state. |
Contributor
Author
|
That's the reason there is no test entire package / file, since the client does that. |
charlieegan3
force-pushed
the
server-testing
branch
from
1c7fbff to
a91d8b4
Compare
Add test locations worker and notification system for LSP clients. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
Signed-off-by: Charlie Egan <charlie_egan@apple.com>
The clients are able to run all tests in file etc. This make the impl more simple. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
force-pushed
the
server-testing
branch
from
a91d8b4 to
cb1b767
Compare
charlieegan3
changed the title
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Feb 24, 2026
This was missed in open-policy-agent#1888 This makes test locations more similar to diagnostics. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Feb 24, 2026
This was missed in open-policy-agent#1888 This makes test locations more similar to diagnostics. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Feb 24, 2026
This was missed in open-policy-agent#1888 This makes test locations more similar to diagnostics. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Feb 25, 2026
This was missed in open-policy-agent#1888 This makes test locations more similar to diagnostics. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
charlieegan3
added a commit
that referenced
this pull request
Feb 25, 2026
This was missed in #1888 This makes test locations more similar to diagnostics. Signed-off-by: Charlie Egan <charlie_egan@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see open-policy-agent/vscode-opa#408 for client implementation and video.
Draft until we get open-policy-agent/opa#8362 in as it's manually referenced atm.