-
Notifications
You must be signed in to change notification settings - Fork 52
lsp: Implement LSP opaTestProvider feature in language server #1888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
charlieegan3
merged 3 commits into
open-policy-agent:main
from
charlieegan3:server-testing
Feb 24, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # METADATA | ||
| # description: | | ||
| # This returns a set of test_ rule locations in a given module. | ||
| # Used by the regal/testLocations method in the LSP to have clients know | ||
| # where tests are. | ||
| package regal.lsp.testlocations | ||
|
|
||
| import data.regal.ast | ||
| import data.regal.result as rs | ||
|
|
||
| # METADATA | ||
| # description: | | ||
| # result contains a list of locations. A location is test name, package and | ||
| # the location (which has start and end char range too). | ||
| result contains object.union(loc, { | ||
| "package": _package_ref_string, | ||
| "name": ast.ref_static_to_string(test.head.ref), | ||
| }) if { | ||
| some test in ast.tests | ||
|
|
||
| loc := rs.location(test.head) | ||
| } | ||
|
|
||
| _package_ref_string := ast.ref_to_string(input.package.path) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| package regal.lsp.testlocations_test | ||
|
|
||
| import data.regal.lsp.testlocations | ||
|
|
||
| test_multiple_test_rules if { | ||
| policy := `package foo_test | ||
|
|
||
| test_1 if { | ||
| 1 == 2 | ||
| } | ||
|
|
||
| test_2 if true | ||
|
|
||
| test_3 if { | ||
| 1 == 2 | ||
| 2 == 1 | ||
| } | ||
| ` | ||
|
|
||
| result := testlocations.result with input as regal.parse_module("file://foo_test.rego", policy) | ||
|
|
||
| { | ||
| { | ||
| "package": "data.foo_test", | ||
| "name": "test_1", | ||
| "location": { | ||
| "col": 1, | ||
| "row": 3, | ||
| "end": {"col": 7, "row": 3}, | ||
| "file": "file://foo_test.rego", | ||
| "text": "test_1 if {", | ||
| }, | ||
| }, | ||
| { | ||
| "package": "data.foo_test", | ||
| "name": "test_2", | ||
| "location": { | ||
| "col": 1, | ||
| "row": 7, | ||
| "end": {"col": 7, "row": 7}, | ||
| "file": "file://foo_test.rego", | ||
| "text": "test_2 if true", | ||
| }, | ||
| }, | ||
| { | ||
| "package": "data.foo_test", | ||
| "name": "test_3", | ||
| "location": { | ||
| "col": 3, | ||
| "row": 9, | ||
| "end": {"col": 9, "row": 9}, | ||
| "file": "file://foo_test.rego", | ||
| "text": " test_3 if {", | ||
| }, | ||
| }, | ||
| } == result | ||
| } | ||
|
|
||
| test_no_test_rules if { | ||
| policy := `package foo_test` | ||
|
|
||
| result := testlocations.result with input as regal.parse_module("file://foo_test.rego", policy) | ||
|
|
||
| set() == result | ||
| } | ||
|
|
||
| test_non_test_package if { | ||
| policy := `package foo | ||
|
|
||
| test_foo if true | ||
| ` | ||
|
|
||
| result := testlocations.result with input as regal.parse_module("file://foo.rego", policy) | ||
|
|
||
| {{ | ||
| "package": "data.foo", | ||
| "name": "test_foo", | ||
| "location": { | ||
| "col": 1, | ||
| "row": 3, | ||
| "end": {"col": 9, "row": 3}, | ||
| "file": "file://foo.rego", | ||
| "text": "test_foo if true", | ||
| }, | ||
| }} == result | ||
| } | ||
|
|
||
| test_funny_test_names_package if { | ||
| policy := `package foo | ||
|
|
||
| foo.bar.test_me if { | ||
| false | ||
| } | ||
|
|
||
| foo.bar.test_me.baz if { | ||
| false | ||
| } | ||
| ` | ||
|
|
||
| result := testlocations.result with input as regal.parse_module("file://foo.rego", policy) | ||
|
|
||
| { | ||
| { | ||
| "package": "data.foo", | ||
| "name": "foo.bar.test_me", | ||
| "location": { | ||
| "col": 1, | ||
| "row": 3, | ||
| "end": {"col": 16, "row": 3}, | ||
| "file": "file://foo.rego", | ||
| "text": "foo.bar.test_me if {", | ||
| }, | ||
| }, | ||
| { | ||
| "package": "data.foo", | ||
| "name": "foo.bar.test_me.baz", | ||
| "location": { | ||
| "col": 1, | ||
| "row": 7, | ||
| "end": {"col": 20, "row": 7}, | ||
| "file": "file://foo.rego", | ||
| "text": "foo.bar.test_me.baz if {", | ||
| }, | ||
| }, | ||
| } == result | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <!-- markdownlint-disable MD041 --> | ||
|
|
||
| [](https://github.com/open-policy-agent/regal/actions) | ||
|  | ||
|  | ||
| [](https://codecov.io/github/StyraInc/regal) | ||
| [](https://github.com/open-policy-agent/regal/releases) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we need? Ah, the runtime bits. 💡